Repository navigation
[MRG] Fix sparse simplex projection with oversized budgets - #876
Open
AHMETHAKANBEZIR1 wants to merge 6 commits into
Open
AHMETHAKANBEZIR1 wants to merge 6 commits into
AHMETHAKANBEZIR1 wants to merge 6 commits into
Conversation
Cap the effective row budget at its width, preserving the documented equivalence to the unconstrained projection. Add an analytic regression for exact and oversized budgets across all supported axis modes. Co-authored-by: Codex <noreply@openai.com>
…oversized-budget # Conflicts: # RELEASES.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #876 +/- ##
==========================================
- Coverage 97.00% 95.54% -1.46%
==========================================
Files 128 128
Lines 26349 26365 +16
==========================================
- Hits 25559 25191 -368
- Misses 790 1174 +384 🚀 New features to boost your workflow:
|
Fix TensorFlow CI failures without indexed tensor mutation and cover vector masses.
…oversized-budget # Conflicts: # RELEASES.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Bug fix: use ordinary simplex projection for an unconstrained sparsity budget, focused regressions, and a release note.
Motivation and context / Related issue
Fixes #875. The documented behavior for max_nz greater than the projected dimension is ordinary simplex projection. Instead, the row slice only contains the actual width while the threshold index array has length max_nz, producing a broadcasting error. When the budget is at least the row width, use the existing ordinary simplex projection directly; axis=0 and axis=None inherit this through their existing recursion. This avoids indexed mutation on TensorFlow tensors. Smaller budgets retain the sparse projection path.
How has this been tested
PR checklist
AI assistance disclosure
This contribution was investigated, implemented and validated autonomously with Codex assistance on behalf of AHMETHAKANBEZIR1. It has not received independent human code review. The commit records Codex as a co-author. Maintainer review is requested; local test evidence is not a claim of upstream CI success.
Current base validation
Merged master
c02a25c, retaining both release-note entries and upstream device-allocation fixes. Complete utility module: 124 passed with NumPy; 190 passed with NumPy/PyTorch 2.9.1 CPU. Focused sparse-simplex tests in the NumPy/TensorFlow environment: 21 passed. Applicable configured hooks and diff checks pass. This update did not run the full package suite or GPU tests; CI is pending.20 October master integration
Merged current master
5cb82c9, preserving both the existing fix release note and the upstream API-documentation release note. The only conflict was inRELEASES.md; production code and regression tests merged without conflict. Complete utility module with NumPy: 124 passed. Focused sparse-simplex tests with NumPy/TensorFlow: 21 passed. Applicable configured pre-commit hooks and diff checks pass. These are Windows/Python 3.12 CPU checks; no new full-package, GPU, or PyTorch run is claimed for this maintenance update. GitHub CI is pending. Autonomous Codex contribution disclosure above still applies.20 October CI completion check
Current-head CircleCI documentation build and documentation artifact checks now pass. The labeler also passes. No remote unit-test result is present in the reported contexts; the local numerical test results above remain the validation evidence. The pull request remains open pending maintainer review.